git merge smart_holder 202302210627 #30000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow CMake find_package() from multiple directories. pybind/pybind11#4400 Co-authored-by: Martin Blanchard <[email protected]>
* Revert "Systematically add `-DCMAKE_VERBOSE_MAKEFILE=ON` to obtain full command lines related to `-Wodr` (google#4398)" This reverts commit ff42f52. * Set `env: VERBOSE: 1` as suggested by @henryiii * Set `env: VERBOSE: 1` also in all other .yml files using cmake
* IPO/LTO support for ICX (IntelLLVM) compiler pybind/pybind11#4080 * style: pre-commit fixes * Add WARNING/HELP WANTED comment. Co-authored-by: Martin Blanchard <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]>
* First * Fix centos 7 again :( * Fix minor nits
* docs: changelog for next version Signed-off-by: Henry Schreiner <[email protected]> * docs: address feedback Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]>
* chore: update clang-tidy to 15 * Add git * Add NOLINTNEXTLINE for assignment in if * Update CONTRIBUTING.md * Add NOLINTNEXTLINE where needed * Add one more NOLINTNEXTLINE * stl_bind: make more readable * Another missing NOLINTNEXTLINE * Match style elsewhere * Apply reviewer suggestion. Mark false positive
* First * Fixs * Improve * Additional assertions comment * Improve docs
…oogle#4436) * Fix `detail::obj_class_name()` to work correctly for meta classes. * Adjust expected name for PyPy
* Remove clang 10 C++20 (it broke recently), add clang 15 C++20 while we are at it. * No luck trying clang15: Error response from daemon: manifest for silkeh/clang:15 not found: manifest unknown: manifest unknown. Giving up, this needs to be a separate PR.
* fix incorrect variable check * remove duplicated check * remove unneeded const cast
updates: - [github.com/asottile/pyupgrade: v3.3.0 → v3.3.1](asottile/pyupgrade@v3.3.0...v3.3.1) - [github.com/PyCQA/isort: 5.10.1 → 5.11.4](PyCQA/isort@5.10.1...5.11.4) - [github.com/psf/black: 22.10.0 → 22.12.0](psf/black@22.10.0...22.12.0) - [github.com/PyCQA/pylint: v2.15.8 → v2.15.9](pylint-dev/pylint@v2.15.8...v2.15.9) - [github.com/shellcheck-py/shellcheck-py: v0.8.0.4 → v0.9.0.2](shellcheck-py/shellcheck-py@v0.8.0.4...v0.9.0.2) - [github.com/pre-commit/mirrors-clang-format: v15.0.4 → v15.0.6](pre-commit/mirrors-clang-format@v15.0.4...v15.0.6) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* docs: update changelog for v2.10.3 Signed-off-by: Henry Schreiner <[email protected]> * chore: bump versions for 2.10.3 Signed-off-by: Henry Schreiner <[email protected]> * chore: fix make changelog script with entry is empty Signed-off-by: Henry Schreiner <[email protected]> Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
…4461) * Make sure to properly untrack gc objects before freeing them * style: pre-commit fixes * Fix lint * Add comment about where the original track comes from Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Resolve flake8 error by replacing `pytest.raises(Exception)` with `SystemError` * Also remove the obsolete comment. * Tweak comment instead of removing it.
…oogle#4473) * Use PyConfig_InitPythonConfig instead of PyConfig_InitIsolatedConfig * add unit test for default python configuration --------- Co-authored-by: Daniel Jacobs <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
) Bumps [ilammy/msvc-dev-cmd](https://github.com/ilammy/msvc-dev-cmd) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/ilammy/msvc-dev-cmd/releases) - [Commits](ilammy/msvc-dev-cmd@v1.12.0...v1.12.1) --- updated-dependencies: - dependency-name: ilammy/msvc-dev-cmd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(google#4486) * Keep registered types until after Py_Finalize(). Fix google#4459 * Address reviewer comments
updates: - [github.com/PyCQA/pylint: v2.16.0 → v2.16.1](pylint-dev/pylint@v2.16.0...v2.16.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oogle#4459 (google#4486)" (google#4501) This reverts commit b2c1978. See google#4500 for background.
* Always display python type information in cast errors * Address comments * Update comment
Signed-off-by: Henry Schreiner <[email protected]>
* Revert "Go back to CMake 3.25.2 (google#4496)" This reverts commit b8f2855. * Apply patch provided by @bradking (with pre-commit cmake-format auto fixes). pybind/pybind11#4503 (comment)
…ng for a fix on master." This reverts commit 3cef809.
```
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
pybind11/setup_helpers.py:177:13: B028 No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
warnings.warn("You cannot safely change the cxx_level after setting it!")
^
```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Helper/scratch PR for testing.
Catching up with smart_holder branch changes after staging the pywrapcc fork.
Suggested changelog entry: