Skip to content

Fix packed enum decoding benchmark #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Fix packed enum decoding benchmark #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d14e62c
Fix packed enum decoding benchmark
osa1 May 7, 2025
e52ed5d
Fix warn
osa1 May 7, 2025
f7cb25d
Fix warn
osa1 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions benchmarks/bin/binary_decode_packed.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,35 @@ class PackedEnumDecodingBenchmark extends BenchmarkBase {
PackedEnumDecodingBenchmark() : super('PackedEnumDecoding') {
final rand = Random(123);
final message = PackedFields();
final numEnums = Enum.values.length;
final numEnums = Enum1.values.length;
for (var i = 0; i < 1000000; i += 1) {
message.packedEnum.add(Enum.values[rand.nextInt(numEnums)]);
message.packedEnum1.add(Enum1.values[rand.nextInt(numEnums)]);
}
encoded = message.writeToBuffer();
}

@override
void setup() {
// Decode different enums to prevent TFA from specializing enum decoding
// code to one type.
final rand = Random(123);
final message = PackedFields();
for (var i = 0; i < 100; i += 1) {
message.packedEnum1.add(Enum1.values[rand.nextInt(Enum1.values.length)]);
}
for (var i = 0; i < 100; i += 1) {
message.packedEnum2.add(Enum2.values[rand.nextInt(Enum2.values.length)]);
}
final encoded = message.writeToBuffer();
final decoded = PackedFields()..mergeFromBuffer(encoded);
if (decoded.packedEnum1.length != 100) {
throw AssertionError('BUG');
}
if (decoded.packedEnum2.length != 100) {
throw AssertionError('BUG');
}
}

@override
void run() {
sink = PackedFields()..mergeFromBuffer(encoded);
Expand Down
23 changes: 16 additions & 7 deletions benchmarks/protos/packed_fields.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,22 @@ message PackedFields {
repeated sint32 packedSint32 = 5 [packed = true];
repeated sint64 packedSint64 = 6 [packed = true];
repeated bool packedBool = 7 [packed = true];
repeated Enum packedEnum = 8 [packed = true];
repeated Enum1 packedEnum1 = 8 [packed = true];
repeated Enum2 packedEnum2 = 9 [packed = true];
}

enum Enum {
ENUM_1 = 0;
ENUM_2 = 1;
ENUM_3 = 2;
ENUM_4 = 4;
ENUM_5 = 5;
enum Enum1 {
ENUM_1_1 = 0;
ENUM_1_2 = 1;
ENUM_1_3 = 2;
ENUM_1_4 = 4;
ENUM_1_5 = 5;
}

enum Enum2 {
ENUM_2_1 = 0;
ENUM_2_2 = 1;
ENUM_2_3 = 2;
ENUM_2_4 = 4;
ENUM_2_5 = 5;
}