Allow cross-compiling AOT snapshots in benchmark builder #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkustermann
approved these changes
Jul 8, 2022
| } | ||
|
|
||
| /// Maps `--aot-target` arguments to their [AotTarget]s | ||
| const aotTargets = <String, AotTarget>{ |
Collaborator
There was a problem hiding this comment.
(to avoid duplication you could use AotTarget.values and their string representation)
| }); | ||
| } | ||
|
|
||
| const aotTarget = Target('aot', aotProcessArgs); |
Collaborator
There was a problem hiding this comment.
Is this aotTarget and aotProcessArgs unused now?
| return Target('aot', (sourceFile) { | ||
| final baseName = path.basename(sourceFile); | ||
| final baseNameNoExt = path.withoutExtension(baseName); | ||
| // TODO: Do we need `-Ddart.vm.product=true`? |
Member
Author
|
Not sure if this is still necessary... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #698 we forgot to add cross-compilation support to benchmark builder, which
broke Golem.
This PR implements cross compilation support for AOT snapshots.
Changes:
AOT target is no longer enabled by default
When using
--target=aot, we now expect one extra parameter and one env variable:--aot-target=[x64|armv7hf|armv8]target platform of the snapshot$DART_SDKenv variable specifies the SDK path. We use this path to invokeprecompiler2.We could avoid adding
--aot-targetwith a syntax like--target=aot=x64. Idon't know how common this syntax is.
Path to Dart SDK is an env variable as in my experience you usually set it in
your shell rc and we have other dev tools that expect
DART_SDKto be set.@mkustermann @sigurdm any thoughts?