Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions .github/workflows/benchmark.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,36 +3,38 @@ permissions: read-all

on:
pull_request:
branches:
push:
branches: [ master ]
branches: [master]
schedule:
- cron: '0 0 * * 0' # weekly
- cron: "0 0 * * 0" # weekly

defaults:
run:
working-directory: benchmarks

jobs:
build:
runs-on: ubuntu-latest
defaults:
run:
working-directory: benchmarks
strategy:
fail-fast: false
matrix:
sdk: dev
sdk: [dev]

steps:
- uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c
with:
sdk: ${{matrix.sdk}}

- run: ../tool/setup.sh

- run: dart pub get

- run: ./tool/compile_protos.sh

- run: dart analyze --fatal-infos

- run: dart format --output=none --set-exit-if-changed .

- run: ./../tool/setup.sh

- run: ./tool/compile_protos.sh
if: ${{ matrix.sdk == 'dev' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do most people develop with dev version? I use stable, so if this fails with a formatting error I'll have the install the dev version just to format.

If most people develop using stable we should check formatting with stable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly going off what I saw in this repo - one workflow was only using dev, so I set the formatting for it and the other workflow to both check against dev.

It's somewhat rare that formatting really differs between versions; when it does you can just work around it locally if necessary. But good for a CI to just test against a single version, so they don't try and validate formatting against stable, and then again against dev for instance.


- run: dart tool/compile_benchmarks.dart
20 changes: 11 additions & 9 deletions .github/workflows/protobuf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,19 @@ permissions: read-all

on:
pull_request:
branches:
push:
branches: [ master ]
branches: [master]
schedule:
- cron: '0 0 * * 0' # weekly
- cron: "0 0 * * 0" # weekly

defaults:
run:
working-directory: protobuf

jobs:
validate-protobuf:
defaults:
run:
working-directory: protobuf
build:
strategy:
fail-fast: false
matrix:
sdk: [stable, dev]
os: [ubuntu-latest, macos-latest, windows-latest]
Expand All @@ -27,14 +28,15 @@ jobs:
with:
sdk: ${{matrix.sdk}}

- run: ../tool/setup.sh

- run: dart pub get

- run: dart analyze --fatal-infos

- run: dart format --output=none --set-exit-if-changed .
if: ${{ matrix.sdk == 'dev' }}

- run: dart test

- run: dart test -p chrome -c dart2js

- run: dart test -p chrome -c dart2wasm
20 changes: 10 additions & 10 deletions .github/workflows/protoc_plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,20 @@ permissions: read-all

on:
pull_request:
branches:
push:
branches: [ master ]
branches: [master]
schedule:
- cron: '0 0 * * 0' # weekly
- cron: "0 0 * * 0" # weekly

defaults:
run:
working-directory: protoc_plugin

jobs:
build:
runs-on: ubuntu-latest
defaults:
run:
working-directory: protoc_plugin
strategy:
fail-fast: false
matrix:
sdk: [stable, dev]
steps:
Expand All @@ -24,18 +25,17 @@ jobs:
with:
sdk: ${{matrix.sdk}}

- run: dart pub get
- run: ../tool/setup.sh

- run: ./../tool/setup.sh
- run: dart pub get

- run: make protos

- run: dart analyze --fatal-infos

- run: dart format --output=none --set-exit-if-changed lib
if: ${{ matrix.sdk == 'dev' }}

- run: dart test

- run: dart test -p chrome -c dart2js

- run: dart test -p chrome -c dart2wasm
Loading