fix: prevent race condition in heap profiler #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a race condition in the heap profiler that could cause
heap.profile() to return an empty profile if called immediately after heap.start().
The issue was that heap.profile() could be called before the V8 heap profiler had
collected any samples, resulting in a blank snapshot.
This change fixes the issue by introducing a polling mechanism in the C++ addon. The
GetAllocationProfile function now waits for the profiler to collect at least one sample
before returning a profile. This ensures that heap.profile() always returns a valid
profile.
Fixes #310