Skip to content

PoC: add PR trigger + skip deploy on PR #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PoC: add PR trigger + skip deploy on PR #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
name: pull_request

on:
pull_request:
branches: [ main ] # ✅ ab PR par bhi trigger hoga
push:
branches-ignore: '**'

env:
NIXPKGS_ALLOW_UNFREE: 1

jobs:
build-preview:
runs-on: 'ubuntu-24.04'
Expand All @@ -22,6 +27,7 @@ jobs:
with:
name: result
path: ./out/

deploy-preview:
needs:
- build-preview
Expand All @@ -32,11 +38,14 @@ jobs:
with:
name: result
path: ./out/

# ✅ Deploy ko PR events par skip kar do
- name: Deploy to Firebase
if: github.event_name != 'pull_request'
uses: w9jds/firebase-action@master
with:
args: hosting:channel:deploy "$GITHUB_SHA"
env:
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
PROJECT_ID: note-maps
PROJECT_PATH: ./build/firebase/
PROJECT_PATH: ./build/firebase/