Skip to content

Conversation

Siddharth1410
Copy link

@Siddharth1410 Siddharth1410 commented Jan 16, 2024

PR to fix issue - #6866

@Siddharth1410 Siddharth1410 marked this pull request as ready for review January 16, 2024 08:54
AmitPatil05 added a commit to AmitPatil05/guava that referenced this pull request Feb 3, 2024
@chaoren chaoren added type=addition A new feature package=hash status=triaged P3 no SLO java Pull requests that update Java code labels Feb 13, 2024
}

/** Returns the number of bits in the underlying bit array. */
@VisibleForTesting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that we've made it public should we remove the annotation?

The documentation states the following

Do not use this interface for public or protected declarations: it is a fig leaf for bad design, and it does not prevent anyone from using the declaration---and experience has shown that they will. If the method breaks the encapsulation of its class, then its internal representation will be hard to change. Instead, use RestrictedApiChecker , which enforces fine-grained visibility policies.

}

/** Returns the number of bits in the underlying bit array. */
@VisibleForTesting

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@SAIVARDHAN15
Copy link

hey, anyone working on #6923? ,
if not, I am glad to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code P3 no SLO package=hash status=triaged type=addition A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants