Use UFCS for with_message assertions
#654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_775268801
branch
8 times, most recently
from
4201b70 to
fd05494
Compare
Before this CL, the assertion macro variants which accept messages would add the message via a call to the `with_message` method from the `GoogleTestSupport` trait. However, that trait may not be imported if users are not bringing in the full googletest prelude. This CL switches those method calls to UFCS and adds a utility method `and_log_failure_with_message` in order to make such calls more readable. PiperOrigin-RevId: 775593149
copybara-service
bot
force-pushed
the
test_775268801
branch
from
fd05494 to
faec46f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UFCS for
with_messageassertionsBefore this CL, the assertion macro variants which accept messages
would add the message via a call to the
with_messagemethod from theGoogleTestSupporttrait. However, that trait may not be imported ifusers are not bringing in the full googletest prelude.
This CL switches those method calls to UFCS and adds a utility method
and_log_failure_with_messagein order to make such calls more readable.