Skip to content

Add GetTime method to Timestamp #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Add GetTime method to Timestamp #2743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3686f2d
Add GetTime() to Timestamp
6543 Apr 8, 2023
8508610
Apply suggestions from code review
6543 Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions github/timestamp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ func (t Timestamp) String() string {
return t.Time.String()
}

// GetTime returns std time.Time.
func (t *Timestamp) GetTime() *time.Time {
if t == nil {
return nil
}
return &t.Time
}

// UnmarshalJSON implements the json.Unmarshaler interface.
// Time is expected in RFC3339 or Unix format.
func (t *Timestamp) UnmarshalJSON(data []byte) (err error) {
Expand Down
11 changes: 11 additions & 0 deletions github/timestamp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,17 @@ func TestWrappedTimestamp_Unmarshal(t *testing.T) {
}
}

func TestTimestamp_GetTime(t *testing.T) {
var t1 *Timestamp
if t1.GetTime() != nil {
t.Errorf("nil timestamp should return nil, got: %v", t1.GetTime())
}
t1 = &Timestamp{referenceTime}
if !t1.GetTime().Equal(referenceTime) {
t.Errorf("want reference time, got: %s", t1.GetTime().String())
}
}

func TestWrappedTimestamp_MarshalReflexivity(t *testing.T) {
testCases := []struct {
desc string
Expand Down