emu/containers: return emulator ID if image is not available locally #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danish Prakash <[email protected]>
The script currently relies on compose v1 and fails if it's not intalled. Check whether compose v2 is installed and use it if available. Signed-off-by: Danish Prakash <[email protected]>
If the image isn't available in the local docker store, an empty string is passed which is an invalid tag for docker build, replace that empty string with emulator ID. Signed-off-by: Danish Prakash <[email protected]>
Signed-off-by: Danish Prakash <[email protected]>
|
This PR is very helpful. Is anyone able to merge this? @pokowaka ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danish Prakash [email protected]