Add support to Android 12 (S) images #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I tried to fix my CLA. I think now it should be working. |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the current version didn't support the newest versions of emulators (using interactive mode), I've added a line to add the support in emu_downloads_menu.py.
However, I have trouble concerning the unzipping of the image through the default Docker system image template. Apparently, there is some bug in the latest unzip version (6.0-r9) to detect zip bombs. This version was considering the Android 12 system images' zips as possibles zip bombs. I fixed it by downgrading the alpine version to v3.3 considering it uses the unzip version 6.0-r1. I've not tested using some new alpine versions rather than the latest one to verify in which version of alpine and unzip this issue started to happen.
Everything seems to be working though.