Fix a series of small issues #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pokowaka
commented
Aug 27, 2021
pokowaka
commented
- Add support for pinging external hosts
- Fix logcat parameter for newer system images
- Enable injection of public adb key
added 3 commits
August 27, 2021 11:39
This enables the injection of the public adb key. This way the secret key will not be embedded in the container. The emulator itself will *NOT* be able to interact with the device itself. For example it cannot generate a bugreport. Fixes google#247
Newer emulators require the -logcat flag or they will not produce any output. Bug: 185392411
The emulator needs the ping package from the os in order for ping to work from adb. We now install ping to make sure we can ping the outside world. Fixes google#147
davidmathis
reviewed
Aug 27, 2021
Contributor
davidmathis
left a comment
davidmathis
left a comment
There was a problem hiding this comment.
LGTM! Thanks again @pokowaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.