-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add a2a agent card generation with the CLI #3606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add a2a agent card generation with the CLI #3606
Conversation
Summary of ChangesHello @guillaumeblaquiere, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the ADK (Agent Development Kit) by adding a new command-line interface tool, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @guillaumeblaquiere, thank you for creating this PR! To help us review this PR more effectively, could you please provide the following:
This information will help reviewers to review your PR more efficiently. You can find more details in our contribution guidelines. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new CLI command, generate_agent_card, for A2A agent card generation. The implementation is well-structured, with good error handling for optional dependencies and for processing multiple agents. The new command is correctly integrated into the existing CLI tool. I've added a few comments, mostly related to code style and minor improvements in the new cli_generate_agent_card.py file. The new test case in test_fast_api.py is also a great addition to ensure the A2A runner factory works as expected.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi @guillaumeblaquiere , Thank you for your contribution through this pull request! |
This PR introduces a new CLI command, generate_agent_card, to the ADK. This command simplifies the setup for A2A (Agent-to-Agent) communication by automating the generation of Agent Cards. It scans the project directory for available agents and produces the necessary JSON configuration for each one.
Key Features
protocol,host, andportused in the agent's endpoint URL.--create-fileflag to automatically save the generated configuration asagent.jsonwithin each agent's directory.Usage Examples
Print Agent Cards to console:
Generate agent.json files for all agents with a custom host and port: