Skip to content

Conversation

@ggamsso
Copy link

@ggamsso ggamsso commented Nov 14, 2025

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

2. Or, if no issue exists, describe the change:

Problem:

  • The code always created a new TracerProvider and invoked trace.set_tracer_provider(...), regardless of whether another module had already initialized a provider.
  • If another module already created the TracerProvider, calling trace.set_tracer_provider(...) again triggers a warning message (opentelemetry/sdk/trace/__init__.py:_set_tracer_provider).

Overriding of current TracerProvider is not allowed

Solution:

  • Obtain the current TracerProvider via trace.get_tracer_provider().
  • If the returned tracer_provider is a ProxyTracerProvider, it indicates that no real provider has been set yet.
  • In that case, create a new TracerProvider and call trace.set_tracer_provider(...) at the end to install it.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

========== 3167 passed, 2379 warnings in 114.36s (0:01:54) ==========

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@google-cla
Copy link

google-cla bot commented Nov 14, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ggamsso, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the OpenTelemetry TracerProvider setup within the _setup_telemetry function. The primary goal is to ensure that a new TracerProvider is only created and installed if one is not already active, thereby preventing unnecessary re-initialization and avoiding warnings related to overriding an existing provider. This improves the robustness and compatibility of the telemetry configuration.

Highlights

  • Conditional TracerProvider Initialization: The TracerProvider is now initialized only if one has not already been set, preventing redundant re-initialization.
  • Warning Prevention: This change resolves a warning message (Overriding of current TracerProvider is not allowed) that occurred when trace.set_tracer_provider(...) was called multiple times.
  • Improved OpenTelemetry Integration: The system now gracefully handles scenarios where other modules might have already configured an OpenTelemetry TracerProvider.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the tracing [Component] This issue is related to OpenTelemetry tracing label Nov 14, 2025
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 14, 2025

Response from ADK Triaging Agent

Hello @ggamsso, thank you for creating this PR!

In order to get this PR reviewed and merged, could you please:

  • Sign our Contributor License Agreement (CLA). You can find more information at https://cla.developers.google.com/.
  • Provide a plan for manual end-to-end (E2E) tests in the PR description. This will help reviewers to verify your changes.

Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the telemetry setup to avoid overriding an existing TracerProvider. The change correctly checks for a ProxyTracerProvider before creating and setting a new one, which prevents warnings when another module has already initialized a provider. The implementation is correct. I've added one suggestion to simplify the logic slightly for improved readability.

@ryanaiagent ryanaiagent self-assigned this Nov 14, 2025
@ryanaiagent
Copy link
Collaborator

Hi @ggamsso ,Thank you for your contribution! We appreciate you taking the time to submit this pull request.
Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tracing [Component] This issue is related to OpenTelemetry tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants