Skip to content

Make wait option default to false #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make wait option default to false #579

wants to merge 1 commit into from

Conversation

@marcusthelin
Copy link

@marcusthelin marcusthelin commented Sep 3, 2025

When the wait option was introduced, it was set to true as default. The way this flag works in the gcloud CLI is that it will execute the job and then wait for it to succeed. This is a major change in the action's behavior, and should be opt-in.

Fixes #578

@marcusthelin marcusthelin requested a review from a team as a code owner September 3, 2025 08:27
@marcusthelin marcusthelin mentioned this pull request Sep 3, 2025
Closed
@bpingris
Copy link

bpingris commented Sep 3, 2025 •
edited
Loading

wait: (Optional, default: true) If true, the action will wait for the job to complete before exiting. This option only applies to jobs.

there is also this part in the README where you could change the default: true to false

@sethvargo sethvargo mentioned this pull request Sep 3, 2025
Merged
google-github-actions-bot pushed a commit that referenced this pull request Sep 3, 2025
@sethvargo
Make "wait" default to false (#583)
41b25ce 
This was an unintentional breaking change, but we didn't catch it
because GitHub changed how floating tags work.

- Closes
#578
- Closes
#579
@marcusthelin marcusthelin deleted the make-wait-default-false branch September 4, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethvargo sethvargo Awaiting requested review from sethvargo sethvargo is a code owner automatically assigned from google-github-actions/maintainers

@verbanicm verbanicm Awaiting requested review from verbanicm verbanicm is a code owner automatically assigned from google-github-actions/maintainers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2.7.5 triggers automatic execution of jobs after deployment

2 participants

@marcusthelin @bpingris