Skip to content

Fix source URLs for glm.* members. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

markmcd
Copy link
Member

@markmcd markmcd commented Oct 30, 2023

GLAPI members defined in a versioned package (e.g. v1beta3) were generating an incorrect URL for the "view on github" link.

To test the regex I ran it on a suspended instance of the script:

diff -u <(egrep -Iir 'generativelanguage_\w+\.types' docs/api/google/ai/generativelanguage/ --include=*.md) \
        <(egrep -Iir 'generativelanguage_\w+.types' docs/api/google/ai/generativelanguage/ --include=*.md)

Output here, but it only matched <a href />s.

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.

GLAPI members defined in a versioned package (e.g. `v1beta3) were
generating an incorrect URL for the "view on github" link.

To test the regex I ran it on a suspended instance of the script:

```
diff -u <(egrep -Iir 'generativelanguage_\w+\.types' docs/api/google/ai/generativelanguage/ --include=*.md) \
        <(egrep -Iir 'generativelanguage_\w+.types' docs/api/google/ai/generativelanguage/ --include=*.md)
```

Output [here](http://go/paste/6300090913259520), but it only matched
`<a href />`s.
@markmcd markmcd requested a review from a team as a code owner October 30, 2023 06:11
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 30, 2023
@markmcd
Copy link
Member Author

markmcd commented Oct 30, 2023

See also cl/577731209 for the diff.

Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

@MarkDaoust MarkDaoust merged commit 152d2cf into google-gemini:main Oct 31, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 31, 2023
@markmcd markmcd deleted the fixsrcurls branch November 1, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants