Skip to content

Update gspread_client.py #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Update gspread_client.py #82

merged 1 commit into from
Oct 11, 2023

Conversation

sbagri
Copy link
Contributor

@sbagri sbagri commented Oct 11, 2023

Inside google, we are removing support for from gspread import gspread

Description of the change

remove support for from gspread import gspread

Motivation

When gspread is installed through pip, it can be used as import gspread

Type of change

Choose one: Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.
    I am already a Googler so I don't need to sign the CLA as the CLA text says.

Inside google, we  are removing support for `from gspread import gspread`
@sbagri sbagri requested a review from a team as a code owner October 11, 2023 16:51
@google-cla
Copy link

google-cla bot commented Oct 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 11, 2023
@MarkDaoust
Copy link
Collaborator

Ah, I see what happened (cl/572251129).

Thanks for the fix, but we can't merge this until you sign the CLA.

@MarkDaoust
Copy link
Collaborator

MarkDaoust commented Oct 11, 2023

@google-cla check again please [It's good now, I checked].

@MarkDaoust MarkDaoust merged commit 923d372 into google-gemini:main Oct 11, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 11, 2023
markmcd pushed a commit to markmcd/generative-ai-python that referenced this pull request Oct 30, 2023
Inside google, we  are removing support for `from gspread import gspread`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants