Skip to content

Add metadata handling. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2023
Merged

Add metadata handling. #74

merged 3 commits into from
Oct 10, 2023
+236 −110

Conversation

MarkDaoust
Copy link
Collaborator

  1. Move all the globals in client.py into a _ClientManager class.
  2. L59 Add a default_metadata argument.
  3. If default_metadata is set when creating a client, wrap up all the methods to inject those metadata (HTTP headers when using rest).

@MarkDaoust MarkDaoust requested a review from a team as a code owner October 3, 2023 23:23
@github-actions github-actions bot added the status:awaiting review PR awaiting review from a maintainer label Oct 3, 2023
@MarkDaoust MarkDaoust marked this pull request as draft October 3, 2023 23:23
markmcd
markmcd reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub said you wanted review, but also said that it's a draft, so apologies if this is unnecessary!

@MarkDaoust
Copy link
Collaborator Author

Merge #78 first.

@MarkDaoust MarkDaoust force-pushed the metadata branch 3 times, most recently from f2e3a22 to 6bfb3ed Compare October 5, 2023 23:17
@MarkDaoust MarkDaoust marked this pull request as ready for review October 6, 2023 00:27
@MarkDaoust MarkDaoust force-pushed the metadata branch 3 times, most recently from eb42b85 to 578cb3d Compare October 9, 2023 17:51
@ymodak ymodak added component:python sdk Issue/PR related to Python SDK subcategory:python api labels Oct 9, 2023
markmcd
markmcd approved these changes Oct 10, 2023
View reviewed changes
@MarkDaoust MarkDaoust merged commit 46db06f into google-gemini:main Oct 10, 2023
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 10, 2023
markmcd pushed a commit to markmcd/generative-ai-python that referenced this pull request Oct 30, 2023
@MarkDaoust @markmcd
Add metadata handling. (google-gemini#74)
a12fe9c 
* Add metadata handling.

* Add and fix tests.

* Resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDaoust @markmcd @ymodak