Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 3 additions & 10 deletions .github/workflows/rw-collect-changes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,11 @@ jobs:
base: ${{ inputs.commit-branch }}
filters: |
docs:
- 'gooddata-pandas/**'
- 'gooddata-sdk/**'
- 'packages/gooddata-pandas/**'
- 'packages/gooddata-sdk/**'
- 'docs/**'
python-modules:
- '.docker/**'
- 'gooddata-fdw/**'
- 'gooddata-pandas/**'
- 'gooddata-sdk/**'
- 'packages/**'
- '*.mk'
- 'Makefile'
- 'gooddata-api-client/**'
- 'gooddata-dbt/**'
- 'gooddata-flight-server/**'
- 'gooddata-flexconnect/**'
- 'gooddata-pipelines/**'
19 changes: 7 additions & 12 deletions .github/workflows/rw-python-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,23 +24,21 @@ jobs:
if: ${{ matrix.python_version == 'py313' }}
uses: codecov/codecov-action@v3
with:
files: ./gooddata-sdk/coverage.xml,./gooddata-pandas/coverage.xml,./gooddata-fdw/coverage.xml,./gooddata-flight-server/coverage.xml,./gooddata-flexconnect/coverage.xml
files: ./packages/gooddata-sdk/coverage.xml,./packages/gooddata-pandas/coverage.xml,./packages/gooddata-fdw/coverage.xml,./packages/gooddata-flight-server/coverage.xml,./packages/gooddata-flexconnect/coverage.xml
lint-and-format-check:
runs-on: ubuntu-latest
if: ${{inputs.changed-python-modules == 'true'}}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Set up python 3.13
uses: actions/setup-python@v5
uses: astral-sh/setup-uv@v6
with:
python-version-file: '.python-version'
cache: 'pip'
cache-dependency-path: |
fmt-requirements.txt
python-version: 3.13
- name: Install dependencies
run: |
make dev
uv venv
uv pip install --group lint
- name: pep8 and formatting check
run: |
make format
Expand All @@ -54,13 +52,10 @@ jobs:
uses: actions/setup-python@v5
with:
python-version-file: '.python-version'
cache: 'pip'
cache-dependency-path: |
tox-requirements.txt
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r tox-requirements.txt
python -m pip install uv
uv pip install --group tox --group type --system
- name: mypy check
run: |
make mypy
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN set -x \
ENV PYTHON_TOX_VERSION=4.14.1
ENV PYTHON_TOX_UV_VERSION=1.7.0
RUN set -x \
&& pip3 install tox==${PYTHON_TOX_VERSION} tox-uv==${PYTHON_TOX_UV_VERSION}\
&& pip3 install uv tox==${PYTHON_TOX_VERSION} tox-uv==${PYTHON_TOX_UV_VERSION}\
&& true

COPY .docker/entrypoint.sh /entrypoint.sh
Expand Down
12 changes: 5 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# (C) 2021 GoodData Corporation
# list all full paths to files and directories in CWD containing "gooddata", filter out ones ending by "client"
NO_CLIENT_GD_PROJECTS_ABS = $(filter-out %client, $(wildcard $(CURDIR)/*gooddata*))
NO_CLIENT_GD_PROJECTS_ABS = $(filter-out %client, $(wildcard $(CURDIR)/packages/*gooddata*))
# for each path, take only the base name of the path
NO_CLIENT_GD_PROJECTS_DIRS = $(foreach dir, $(NO_CLIENT_GD_PROJECTS_ABS), $(notdir $(dir)))
# TODO: replace API_VERSION in the future by call to API
Expand All @@ -18,9 +18,7 @@ all:

.PHONY: dev
dev:
rm -rf .venv
python3.13 -m venv .venv --upgrade-deps
.venv/bin/pip3 install -r dev-requirements.txt
uv sync --all-groups
.venv/bin/pre-commit install

.PHONY: lint
Expand Down Expand Up @@ -72,13 +70,13 @@ download:
.PHONY: mypy
mypy:
RESULT=0; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C $${project} $@ || RESULT=$$?; done; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C packages/$${project} $@ || RESULT=$$?; done; \
exit $$RESULT

.PHONY: test
test:
RESULT=0; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C $${project} test || RESULT=$$?; done; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C packages/$${project} test || RESULT=$$?; done; \
exit $$RESULT

.PHONY: release
Expand All @@ -104,7 +102,7 @@ docs:
.PHONY: remove-cassettes
remove-cassettes:
RESULT=0; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C $${project} $@ || RESULT=$$?; done; \
for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C packages/$${project} $@ || RESULT=$$?; done; \
exit $$RESULT

.PHONY: new-docs
Expand Down
22 changes: 0 additions & 22 deletions dev-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion fmt-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion gooddata-dbt/LICENSE.txt

This file was deleted.

5 changes: 0 additions & 5 deletions gooddata-dbt/requirements.txt

This file was deleted.

51 changes: 0 additions & 51 deletions gooddata-dbt/setup.py

This file was deleted.

2 changes: 0 additions & 2 deletions gooddata-dbt/test-requirements.txt

This file was deleted.

2 changes: 0 additions & 2 deletions gooddata-dbt/type-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion gooddata-fdw/LICENSE.txt

This file was deleted.

62 changes: 0 additions & 62 deletions gooddata-fdw/setup.py

This file was deleted.

6 changes: 0 additions & 6 deletions gooddata-fdw/test-requirements.txt

This file was deleted.

2 changes: 0 additions & 2 deletions gooddata-fdw/type-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion gooddata-flexconnect/LICENSE.txt

This file was deleted.

6 changes: 0 additions & 6 deletions gooddata-flexconnect/requirements.txt

This file was deleted.

69 changes: 0 additions & 69 deletions gooddata-flexconnect/setup.py

This file was deleted.

3 changes: 0 additions & 3 deletions gooddata-flexconnect/test-requirements.txt

This file was deleted.

2 changes: 0 additions & 2 deletions gooddata-flexconnect/type-requirements.txt

This file was deleted.

1 change: 0 additions & 1 deletion gooddata-flight-server/LICENSE.txt

This file was deleted.

8 changes: 0 additions & 8 deletions gooddata-flight-server/requirements.txt

This file was deleted.

Loading
Loading