GIP-4: Decentralized Payout/Slashing #244
Conversation
|
This pull request has been linked to Shortcut Story #18728: Verifiers should receive payout in token On-Chain [GIP-4]. |
|
|
||
| // ============ Private Storage ============ | ||
|
|
||
| address private _token; |
There was a problem hiding this comment.
State variable _token can be immutable because I don't think there's a case where an owner would change the payout token. What do you think?
There was a problem hiding this comment.
ideally, there shouldn't be a case but we might mess something up. We can remove but I think we're good, if the users revolt we can explain that this will be removed once the system is complete
| return _token; | ||
| } | ||
|
|
||
| function setToken(address token) external onlyOwner { |
There was a problem hiding this comment.
If _token is updated to be immutable, please remove the setToken function.
There was a problem hiding this comment.
@Elvis339 this contract is updatable and we can always remove this function later but for now we don't want to limit our options, what if we mess up some contract and want to change.
https://app.shortcut.com/golden/story/18728/verifiers-should-receive-payout-in-token-on-chain-gip-4