Skip to content
This repository was archived by the owner on Feb 8, 2022. It is now read-only.

Conversation

@snakorse
Copy link

Fix error on splitting the filename and ext part of transform files having multiple dots, such like "Foo.bar.config", it should create the file named "Foo.bar.Debug.config", not the error one "Foo.Debug.bar".

@golavr golavr self-assigned this Dec 30, 2018
@golavr
Copy link
Owner

golavr commented Dec 30, 2018

Thanks for contributing 👍
just fix the typo spliter -> splitter :)
add some unit tests to cover this case (file.with.more.dots.config) and i'll merge it to master

@golavr golavr added the bug label Dec 30, 2018
@golavr golavr added this to the v3.3 milestone Dec 30, 2018
@golavr
Copy link
Owner

golavr commented Jan 11, 2019

nice work @snakorse 👍

@golavr golavr merged commit fd99dd3 into golavr:master Jan 11, 2019
@golavr golavr self-requested a review January 11, 2019 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants