fix: improve Go detection #5112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
before
after
There is still an unmanaged case:
go 1.22with no toolchain inside thego.modBut this case cannot be caught without calling the Go binary, and I think this is a bad idea.
Also technically, the
goversion inside thego.modis enough to analyze but the problem happens when Go handles thetoolchainversion before running golangci-lint.In this case, Go will install a newer version of Go (go1.23), and the problem will happen.
toolchaindefines the minimum Go compiler version used to build.godefines the minimum Go language version used to write the code.The difference is really important: if your module is a lib, then the user of this lib will rely on
goand not ontoolchain. This is the same thing for the tool pattern, onlygowill be used and not ontoolchain.Related to #4909
Related to #4938