Staticcheck linters configs refactoring #3703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonboom
commented
Mar 18, 2023
| gomodguardCfg *config.GoModGuardSettings | ||
| gosecCfg *config.GoSecSettings | ||
| gosimpleCfg *config.StaticCheckSettings | ||
| gosimpleCfg config.StaticCheckGoSimpleSettings |
Contributor
Author
There was a problem hiding this comment.
I think it doesn't make sense to use pointers here (for other settings too).
Not big memory win, but code is complicated a lot
Antonboom
commented
Mar 18, 2023
| DotImportWhitelist: scconfig.DefaultConfig.DotImportWhitelist, | ||
| HTTPStatusCodeWhitelist: scconfig.DefaultConfig.HTTPStatusCodeWhitelist, | ||
| } | ||
| func staticCheckConfig(settings interface{ ChecksList() []string }) *scconfig.Config { |
Contributor
Author
There was a problem hiding this comment.
Also I tried use generics, but the solution turned out to be less elegant
Member
|
#3555 is about a problem during the generation of the doc, this PR doesn't fix the problem. the deprecated configuration must be kept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3555