dev: replace golangcitest:config by golangcitest:config_path #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
ldez
force-pushed
the
feat/test-config-path
branch
from
9177226 to
c7d9e6d
Compare
ldez
force-pushed
the
feat/test-config-path
branch
from
c7d9e6d to
c2ced0f
Compare
ldez
force-pushed
the
feat/test-config-path
branch
from
7c94d73 to
cc64538
Compare
bombsimon
approved these changes
Aug 15, 2022
Member
bombsimon
left a comment
bombsimon
left a comment
There was a problem hiding this comment.
Nice, this will make it easier to understand how to change settings for your tests and consistent with regular usage! 👍
Co-authored-by: Simon Sawert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of the directive
golangcitest:configbygolangcitest:config_path.golangcitest:config_pathalready existed but we had a mix between the 2 directives.The objective is to simplify maintenance and the contribution by having an identical approach for all tests.
This also simplifies the maintenance of test files which are corrected automatically by the IDEs as soon as the file is edited when you have to update the configuration.