term: remove duplicate flag and add comment on windows #14

aymanbagabas · 2024-02-09T17:24:50Z

Both windows.ENABLE_PROCESSED_INPUT and windows.ENABLE_PROCESSED_OUTPUT have
the same value of 0x1. Using makeRaw on a console output screen buffer handle
wouldn't make sense since on Windows the input handle and the output screen
buffer handle are two separate things.

See https://learn.microsoft.com/en-us/windows/console/setconsolemode

Both `windows.ENABLE_PROCESSED_INPUT` and `windows.ENABLE_PROCESSED_OUTPUT` have the same value of `0x1`. Using `makeRaw` on a console output screen buffer handle wouldn't make sense since on Windows the input handle and the output screen buffer handle are two separate things. See https://learn.microsoft.com/en-us/windows/console/setconsolemode

gopherbot · 2024-02-09T17:35:46Z

This PR (HEAD: 43baa50) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/562779.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-09T17:42:13Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-09T17:48:38Z

Message from Ayman Bagabas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-10T02:20:08Z

Message from qiulaidongfeng:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-10T02:26:52Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-10T02:10:30Z","revision":"5427808fd47b76da35c339fe2923f464db721b45"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-10T02:26:53Z

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-10T02:26:53Z

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-10T02:26:54Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-04T20:55:40Z

This PR (HEAD: 2e39ed2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/562779.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

aymanbagabas · 2025-06-18T16:15:57Z

@ldemailly Could you please take a look at this one?

gopherbot · 2025-06-18T16:33:59Z

Message from Laurent Demailly:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

term_windows.go

gopherbot · 2025-06-18T17:37:49Z

Message from Ayman Bagabas:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-06-18T17:37:56Z

This PR (HEAD: 832fc7e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/term/+/562779.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-06-18T17:51:15Z

Message from Laurent Demailly:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T02:59:41Z

Message from t hepudds:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T02:59:41Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-12T02:48:41Z","revision":"e8996113d65b35c0a7fabc8f21f05c2293c02e6e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T03:12:46Z

Message from t hepudds:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T03:12:46Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T03:12:47Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T17:29:43Z

Message from Jorropo:

Patch Set 3: Code-Review+1 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T17:29:43Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-12T17:18:23Z","revision":"e8996113d65b35c0a7fabc8f21f05c2293c02e6e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T17:36:45Z

Message from Jorropo:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-12T17:36:46Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

ldemailly · 2025-07-14T21:41:48Z

@aymanbagabas can you edit the description to be markdown free and with line breaks (see comment about this in the CL)

aymanbagabas · 2025-07-14T22:09:27Z

@aymanbagabas can you edit the description to be markdown free and with line breaks (see comment about this in the CL)

I've updated the PR description. Thank you for the reminder @ldemailly 🙂

gopherbot · 2025-07-14T22:16:02Z

Message from Ayman Bagabas:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-14T22:37:50Z

Message from Laurent Demailly:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T15:00:52Z

Message from Michael Pratt:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-07-15T15:32:45Z

Message from Cherry Mui:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/562779.
After addressing review feedback, remember to publish your drafts!

Both windows.ENABLE_PROCESSED_INPUT and windows.ENABLE_PROCESSED_OUTPUT have the same value of 0x1. Using makeRaw on a console output screen buffer handle wouldn't make sense since on Windows the input handle and the output screen buffer handle are two separate things. See https://learn.microsoft.com/en-us/windows/console/setconsolemode Change-Id: I19feadf8da303a1ada8e517399416a4730845900 GitHub-Last-Rev: 832fc7e GitHub-Pull-Request: #14 Reviewed-on: https://go-review.googlesource.com/c/term/+/562779 Reviewed-by: Michael Pratt <[email protected]> Reviewed-by: Laurent Demailly <[email protected]> Reviewed-by: Jorropo <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]>

gopherbot · 2025-07-15T16:55:57Z

This PR is being closed because golang.org/cl/562779 has been merged.

ldemailly · 2025-07-15T17:00:22Z

🎉 only took 18 months :) ty!

Merge branch 'master' into win-dup-flag

2e39ed2

aymanbagabas commented Jun 18, 2025

View reviewed changes

term_windows.go Outdated Show resolved Hide resolved

docs: update comment

832fc7e

gopherbot closed this Jul 15, 2025

term: remove duplicate flag and add comment on windows #14

term: remove duplicate flag and add comment on windows #14

Conversation

aymanbagabas commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 9, 2024

Uh oh!

gopherbot commented Feb 10, 2024

Uh oh!

gopherbot commented Feb 10, 2024

Uh oh!

gopherbot commented Feb 10, 2024

Uh oh!

gopherbot commented Feb 10, 2024

Uh oh!

gopherbot commented Feb 10, 2024

Uh oh!

gopherbot commented Feb 4, 2025

Uh oh!

aymanbagabas commented Jun 18, 2025

Uh oh!

gopherbot commented Jun 18, 2025

Uh oh!

Uh oh!

gopherbot commented Jun 18, 2025

Uh oh!

gopherbot commented Jun 18, 2025

Uh oh!

gopherbot commented Jun 18, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

gopherbot commented Jul 12, 2025

Uh oh!

ldemailly commented Jul 14, 2025

Uh oh!

aymanbagabas commented Jul 14, 2025

Uh oh!

gopherbot commented Jul 14, 2025

Uh oh!

gopherbot commented Jul 14, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

gopherbot commented Jul 15, 2025

Uh oh!

ldemailly commented Jul 15, 2025

Uh oh!

Uh oh!

aymanbagabas commented Feb 9, 2024 •

edited

Loading