mime: keep going parsing after trailing semicolon #47029

Illirgway · 2021-07-02T15:08:08Z

gopherbot · 2021-07-02T15:12:21Z

This PR (HEAD: 6372fce) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/332509 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-02T15:14:42Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T16:05:33Z

Message from Damien Neil:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

Illirgway · 2021-07-02T17:22:45Z

How can i write some comment/answer in gerrit from browser?
I suddenly can't find any input or button to do that.

gopherbot · 2021-07-02T17:37:46Z

This PR (HEAD: caae34a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/332509 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

ianlancetaylor · 2021-07-02T19:17:16Z

You have to sign into Gerrit to respond to comments there.

gopherbot · 2021-07-02T19:38:21Z

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T19:43:05Z

Message from Go Bot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T19:50:08Z

Message from Go Bot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

Illirgway · 2021-07-02T19:59:35Z

I sign into Gerrit (in browser) by my email, but I can't find any reply/comment button/input

ianlancetaylor · 2021-07-02T20:04:06Z

When I go to https://golang.org/cl/332509 I see a blue "Reply" button in the middle, near the top, above the description of the change. What do you see?

Illirgway · 2021-07-02T20:12:23Z

I see this

gopherbot · 2021-07-02T21:09:03Z

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T21:09:04Z

Message from Damien Neil:

Patch Set 6: Patch Set 5 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T21:09:05Z

Message from Damien Neil:

Patch Set 6: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T21:09:06Z

Message from Go Bot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T21:21:32Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-02T21:23:47Z

Message from Ian Lance Taylor:

Patch Set 6: Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

ianlancetaylor · 2021-07-02T21:26:17Z

That's odd. You're right, of course: there is no Reply button. Here are examples of what the page should look like for a signed in user: https://gerrit-review.googlesource.com/Documentation/user-review-ui.html . What browser and OS are you using?

It may be appropriate to raise this as an issue with Gerrit. See https://www.gerritcodereview.com/issues.html. Assuming that web page works for you....

Sorry for the difficulties.

Illirgway · 2021-07-03T06:44:26Z

I have 2 js errors in debug console

gr-app.js:23651:328
TypeError: e.composedPath is not a function gr-app.js:23651:328

And can't open (white screen) gerrit's 'add issue' page

gopherbot · 2021-07-04T09:24:53Z

Message from Zeke Lu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-05T11:22:08Z

This PR (HEAD: 7ad670b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/332509 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

ianlancetaylor · 2021-07-05T16:47:23Z

I'm sorry, I have no suggestions. It does seem to work for most people.

What browser and OS are you using?

Illirgway · 2021-07-09T14:55:58Z

FF 56 x64

I don't update it to Quatum yet because of plugins

gopherbot · 2021-10-01T20:16:08Z

Message from Illirgway:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:23Z

Message from Damien Neil:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:24Z

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:25Z

Message from Go Bot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:26Z

Message from Go Bot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:27Z

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:27Z

Message from Damien Neil:

Patch Set 6: Patch Set 5 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:28Z

Message from Damien Neil:

Patch Set 6: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:29Z

Message from Go Bot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:30Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:31Z

Message from Ian Lance Taylor:

Patch Set 6: Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:32Z

Message from Zeke Lu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-08T11:13:33Z

Message from Illirgway:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-09T21:50:16Z

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-09T21:53:07Z

Message from Go Bot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-11-09T22:29:13Z

Message from Go Bot:

Patch Set 8: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/332509.
After addressing review feedback, remember to publish your drafts!

Fixes #46323 Change-Id: Ibd624b1aaa15f907b7eb965b4eaec61018a45486 GitHub-Last-Rev: 7ad670b GitHub-Pull-Request: #47029 Reviewed-on: https://go-review.googlesource.com/c/go/+/332509 Trust: Ian Lance Taylor <[email protected]> Trust: Damien Neil <[email protected]> Reviewed-by: Damien Neil <[email protected]>

gopherbot · 2021-11-09T23:29:08Z

This PR is being closed because golang.org/cl/332509 has been merged.

fix golang#46323: mime: ParseMediaType drops value with trailing semi…

e7d3a1f

…colon SEE golang#46323

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jul 2, 2021

Illirgway changed the title ~~mime: fix ParseMediaType drops value with trailing semicolon #46862~~ mime: fix ParseMediaType drops value with trailing semicolon #46323 Jul 2, 2021

issue golang#46323 test

6372fce

Illirgway changed the title ~~mime: fix ParseMediaType drops value with trailing semicolon #46323~~ mime: fix parsing media types with a trailing semicolon Jul 2, 2021

Illirgway changed the title ~~mime: fix parsing media types with a trailing semicolon~~ mime: fix parsing media types with a trailing semicolon Jul 2, 2021

review changes

caae34a

Illirgway changed the title ~~mime: fix parsing media types with a trailing semicolon~~ mime: keep going parsing after trailing semicolon Jul 3, 2021

small typo fix by Zeke Lu

7ad670b

gopherbot closed this Nov 9, 2021

mime: keep going parsing after trailing semicolon #47029

mime: keep going parsing after trailing semicolon #47029

Uh oh!

Conversation

Illirgway commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

Illirgway commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

ianlancetaylor commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

Illirgway commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianlancetaylor commented Jul 2, 2021

Uh oh!

Illirgway commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

gopherbot commented Jul 2, 2021

Uh oh!

ianlancetaylor commented Jul 2, 2021

Uh oh!

Illirgway commented Jul 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Jul 4, 2021

Uh oh!

gopherbot commented Jul 5, 2021

Uh oh!

ianlancetaylor commented Jul 5, 2021

Uh oh!

Illirgway commented Jul 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Oct 1, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

gopherbot commented Nov 8, 2021

Uh oh!

Illirgway commented Jul 2, 2021 •

edited

Loading

Illirgway commented Jul 2, 2021 •

edited

Loading

Illirgway commented Jul 3, 2021 •

edited

Loading

Illirgway commented Jul 9, 2021 •

edited

Loading