-
Notifications
You must be signed in to change notification settings - Fork 18.3k
Closed
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.compiler/runtimeIssues related to the Go compiler and/or runtime.Issues related to the Go compiler and/or runtime.
Milestone
Description
Opening a tracking issue for something reported to me by @jtagcat via email:
Hey, you made a change with extra newlines: https://cs.opensource.google/go/x/sys/+/661d749b94a62dfdcbe1027bb3c2cdea498377b9
Could you please ensure one (not two) newline at the end of files? It is non-standard and giving errors with my global pre-commit
hook.git diff --check --staged
vendor/golang.org/x/sys/unix/zsyscall_openbsd_386.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_amd64.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_arm64.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_mips64.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_ppc64.go:2300: new blank line at EOF. vendor/golang.org/x/sys/unix/zsyscall_openbsd_riscv64.go:2300: new blank line at EOF.
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_403Thanks
-jc
This is due to a custom generator script I created to generate just these syscall files without running mkall.sh, which can not cross generate for other host arches.
jtagcat
Metadata
Metadata
Assignees
Labels
FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.compiler/runtimeIssues related to the Go compiler and/or runtime.Issues related to the Go compiler and/or runtime.