Skip to content

x/tools/gopls: orphaned file reloading causes unnecessary loads #57053

@findleyr

Description

@findleyr

The current logic of reloadOrphanedFiles causes it to reload irrelevant files in the workspace, once they have been mapped (e.g. because of a branch change).

More generally, we should avoid ever ranging snapshot.files, as it is the set of files previously seen by the snapshot, which is path-dependent and has no intrinsic meaning.

CC @adonovan

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions