x/crypto/ssh: data race in TestHandshakeRekeyDefault

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && `DATA RACE` && `^\s+golang\.org/x/crypto/ssh\.TestHandshakeRekeyDefault`

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Write at 0x00c000152810 by goroutine 26:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x169
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
      /tmp/workdir/go/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /tmp/workdir/go/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:1719 +0xa71
  main.main()
      _testmain.go:321 +0x2e4
==================
--- FAIL: TestHandshakeAEADCipherNoMAC (0.02s)
    testing.go:1312: race detected during execution of test

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && test == "TestHandshakeAEADCipherNoMAC"

2022-11-17 19:18 freebsd-amd64-race crypto@2c476679 go@d96e5847 x/crypto/ssh.TestHandshakeAEADCipherNoMAC (log)

==================
WARNING: DATA RACE
Write at 0x00c000152810 by goroutine 26:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x169
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
      /tmp/workdir/go/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /tmp/workdir/go/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:1719 +0xa71
  main.main()
      _testmain.go:321 +0x2e4
==================
--- FAIL: TestHandshakeAEADCipherNoMAC (0.02s)
    testing.go:1312: race detected during execution of test

— watchflakes

[bcmills]

(attn @FiloSottile @rolandshoemaker @golang/security)

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && `DATA RACE` && `^\s+golang\.org/x/crypto/ssh\.TestHandshakeRekeyDefault`

2022-11-17 19:18 linux-amd64-race crypto@2c476679 go@14074cec x/crypto/ssh.TestHandshakeRekeyDefault (log)

==================
WARNING: DATA RACE
Write at 0x00c0002f4c30 by goroutine 1349:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x199
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1446 +0x216
  testing.runTests()
      /workdir/go/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:1726 +0xa84
  main.main()
      _testmain.go:321 +0x2e9
==================
--- FAIL: TestHandshakeRekeyDefault (0.01s)

— watchflakes

[gopherbot]

Change https://go.dev/cl/456758 mentions this issue: ssh: ensure that handshakeTransport goroutines have finished before Close returns

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/crypto/ssh" && `DATA RACE` && `^\s+golang\.org/x/crypto/ssh\.TestHandshakeRekeyDefault`

2022-12-08 18:21 freebsd-amd64-race crypto@f495dc37 go@63dd7762 x/crypto/ssh.TestHandshakeAEADCipherNoMAC (log)

==================
WARNING: DATA RACE
Write at 0x00c000345050 by goroutine 52:
  golang.org/x/crypto/ssh.(*handshakeTransport).readOnePacket()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:386 +0x169
  golang.org/x/crypto/ssh.(*handshakeTransport).readLoop()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:197 +0x4a
  golang.org/x/crypto/ssh.newClientTransport.func1()
      /tmp/workdir/gopath/src/golang.org/x/crypto/ssh/handshake.go:134 +0x39

...
      /tmp/workdir/go/src/testing/testing.go:1439 +0x213
  testing.runTests()
      /tmp/workdir/go/src/testing/testing.go:1837 +0x7e4
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:1719 +0xa71
  main.main()
      _testmain.go:321 +0x2e4
==================
--- FAIL: TestHandshakeAEADCipherNoMAC (0.02s)
    testing.go:1312: race detected during execution of test

2022-12-08 18:21 linux-amd64-longtest-race crypto@f495dc37 go@9b8750f5 x/crypto/ssh.TestHandshakeRekeyDefault (log)

==================
WARNING: DATA RACE
Read at 0x00c0002a1730 by goroutine 1347:
  golang.org/x/crypto/ssh.TestHandshakeRekeyDefault()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake_test.go:553 +0x3a4
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1575 +0x216
  testing.(*T).Run.func1()
      /workdir/go/src/testing/testing.go:1628 +0x47

...
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake_test.go:108 +0x2e5
  golang.org/x/crypto/ssh.TestHandshakeRekeyDefault()
      /workdir/gopath/src/golang.org/x/crypto/ssh/handshake_test.go:543 +0x1c4
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1575 +0x216
  testing.(*T).Run.func1()
      /workdir/go/src/testing/testing.go:1628 +0x47
==================
--- FAIL: TestHandshakeRekeyDefault (0.01s)
    testing.go:1445: race detected during execution of test

— watchflakes