x/tools/gopls: sometimes documentation on hover is not shown

[inliquid]

1. VS Code
2. go1.16.4
3. gopls@master

For example in case of (*url.URL).Query():

[findleyr]

Thanks for the report. Which gopls commit did you build at? I thought this might be related to recent work on AST trimming, but can't reproduce at tip.

Are you able to repro? If so, can you please capture RPC logs, as described here?
https://github.com/golang/vscode-go/blob/master/docs/troubleshooting.md#collect-gopls-information

[inliquid]

It was built with go install run from the gopls repo.

Unfortunately I can't reproduce it now, it had been in that state for a while, but after restart of VS Code, I can see documentation for this particular function. I'll watch over it and let you know if this repeats.

[ShoshinNikita]

I faced a similar issue. But in my case fields of a struct have disappeared. The first commit with this issue is golang/tools@cd1d088. Note that this behavior is inconsistent (see screenshots)

Steps to reproduce

package main

import (
	"github.com/go-pg/pg/v10/orm"
)

func main() {
	orm.NewQuery(nil, nil)
	(&orm.Query{}).New()
}

1. Go to Definition of orm.NewQuery
2. Hover on the return value
3. Query has ho fields

And

1. Go to Definition of method (*orm.Query).New
2. Hover on Query in the line clone := &Query{
3. Query has fields, but they are poorly formatted

gopls@09ab05b (master)

1	2

gopls@v0.6.11

1	2

[findleyr]

FWIW, I think these are separate issues.

@ShoshinNikita you issue seems to clearly be a result of AST trimming. I am not so sure about the original issue. Keeping this as a single issue until I understand it better.

[gopherbot]

Change https://golang.org/cl/320550 mentions this issue: internal/lsp/source: re-parse if needed when collecting identifier info