x/tools/gopls: nil pointer in analysis

[ilanpillemer]

Please answer these questions before submitting your issue. Thanks!

What did you do?

I had gopls running

What did you expect to see?

gopls doing stuff

What did you see instead?

gopls doing stuff and restarting

stack trace of

[Error - 10:36:37.252 AM] Received #2 ToUTF16Column: column is invalid (-1)


panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1693475]

goroutine 92 [running]:
golang.org/x/tools/internal/lsp/cache.(*actionHandle).analyze(0xc0025b3360, 0x19b0e20, 0xc000270a80, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/cache/analysis.go:149 +0x65
golang.org/x/tools/internal/lsp/cache.(*snapshot).Analyze(0xc0000de820, 0x19b0e20, 0xc000270a80, 0xc0002c47c0, 0x32, 0xc000d83000, 0x88, 0x100, 0x0, 0x101, ...)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/cache/analysis.go:39 +0x25e
golang.org/x/tools/internal/lsp/source.analyses(0x19b0e20, 0xc000270a80, 0x19b3fe0, 0xc0000de820, 0x19b3fa0, 0xc000383b30, 0x0, 0xc0025bb650, 0x1, 0x1)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/source/diagnostics.go:169 +0x294
golang.org/x/tools/internal/lsp/source.Diagnostics(0x19b0e20, 0xc000270a80, 0x19c1540, 0xc00032e900, 0x239a240, 0xc000218340, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/source/diagnostics.go:87 +0x971
golang.org/x/tools/internal/lsp.(*Server).diagnostics(0xc00029cf00, 0x19c1540, 0xc00032e900, 0xc0002f22d0, 0x4b, 0x0, 0x0)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/diagnostics.go:30 +0x2e0
created by golang.org/x/tools/internal/lsp.(*Server).didChange
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/text_synchronization.go:82 +0x373
[Trace - 10:36:50.040 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"file:///","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{},"didChangeConfiguration":{},"didChangeWatchedFiles":{},"symbol":{},"executeCommand":{},"workspaceFolders":true},"textDocument":{"synchronization":{},"completion":{},"hover":{},"signatureHelp":{},"declaration":{},"definition":{},"typeDefinition":{},"implementation":{},"references":{},"documentHighlight":{},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["source.organizeImports"]}}},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"codeLens":{},"documentLink":{},"rename":{},"publishDiagnostics":{},"colorProvider":{},"foldingRange":{},"selectionRange":{}}},"initializationOptions":{"hoverKind":"FullDocumentation","staticcheck":true},"workspaceFolders":[{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm"},{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm/bx-pipe","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm/bx-pipe"},{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler"},{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bxrepl/cmd/bxrepl","name":"/Users/ilanpillemer/Repos/bxbdigital/bxrepl/cmd/bxrepl"}]}

another example

[Trace - 10:36:34.203 AM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2019/11/04 10:36:34 go/packages.Load\n\tpackage = bitbucket.org/bxbdigital/bx-mm/internal/bxcompiler\n\tfiles = [/Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/bx.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/compilerflags.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/fieldtype_string.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/interpreter.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/lexer.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/parser.go /Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler/symbols.go]"}


[Trace - 10:36:34.304 AM] Received response 'textDocument/completion - (2)' in 299ms.
Result: {"isIncomplete":false,"items":[]}


panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1693475]

goroutine 31 [running]:
golang.org/x/tools/internal/lsp/cache.(*actionHandle).analyze(0xc002542d20, 0x19b0e20, 0xc000282a20, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/cache/analysis.go:149 +0x65
golang.org/x/tools/internal/lsp/cache.(*snapshot).Analyze(0xc00025c190, 0x19b0e20, 0xc000282a20, 0xc0001d4f00, 0x32, 0xc001ced800, 0x88, 0x100, 0x0, 0x101, ...)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/cache/analysis.go:39 +0x25e
golang.org/x/tools/internal/lsp/source.analyses(0x19b0e20, 0xc000282a20, 0x19b3fe0, 0xc00025c190, 0x19b3fa0, 0xc00024d0e0, 0x0, 0xc0023810b0, 0x1, 0x1)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/source/diagnostics.go:169 +0x294
golang.org/x/tools/internal/lsp/source.Diagnostics(0x19b0e20, 0xc000282a20, 0x19c1540, 0xc000001980, 0x5400008, 0xc00018c580, 0x0, 0x0, 0x0, 0x0, ...)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/source/diagnostics.go:87 +0x971
golang.org/x/tools/internal/lsp.(*Server).diagnostics(0xc000169ce0, 0x19c1540, 0xc000001980, 0xc00003c1e0, 0x4b, 0x0, 0x0)
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/diagnostics.go:30 +0x2e0
created by golang.org/x/tools/internal/lsp.(*Server).didChange
	/Users/ilanpillemer/go/src/golang.org/x/tools/internal/lsp/text_synchronization.go:82 +0x373
[Trace - 10:36:35.026 AM] Sending request 'initialize - (1)'

Build info

golang.org/x/tools/gopls v0.1.6
    golang.org/x/tools/gopls@(devel)
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/sergi/go-diff@v1.0.0 h1:Kpca3qRNrduNnOQeazBd0ysaKrUJiIuISHxogkT9RPQ=
    golang.org/x/sync@v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=
    golang.org/x/tools@v0.0.0-20191017151554-a3bc800455d5 => ../
    golang.org/x/xerrors@v0.0.0-20190717185122-a985d3407aa7 h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=
    honnef.co/go/tools@v0.0.1-2019.2.3 h1:3JgtbtFHMiCmsznwGVTUWbgGov+pVqnlf1dEJTNAXeM=

Go info

go version go1.13.3 darwin/amd64

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/ilanpillemer/Library/Caches/go-build"
GOENV="/Users/ilanpillemer/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY="bitbucket.org/bxbdigital"
GONOSUMDB="bitbucket.org/bxbdigital"
GOOS="darwin"
GOPATH="/Users/ilanpillemer/go"
GOPRIVATE="bitbucket.org/bxbdigital"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/z4/rs3f6lcs10l9rhf6wg4vdjt80000gn/T/go-build158073267=/tmp/go-build -gno-record-gcc-switches -fno-common"

[gopherbot]

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

[gopherbot]

Change https://golang.org/cl/205161 mentions this issue: internal/lsp: add additional check for analysis value

[stamblerre]

Just mailed CL 205161 to handle this, but I'm curious about how you triggered it. Do you mind rebuilding gopls with this CL (download it by clicking the "..." in the right hand corner and choosing "Download Patch") and sharing the log output?

[ilanpillemer]

I can't work out how to download the patch.. I must be misunderstanding something.
I can only try again later tomorrow though, as have an appointment in the morning. If I were to guess at anything unusual, is I am using go generate in this package for goyacc and stringer and have a yacc y file in it with go code. And it keeps telling me the yacc file doesn't exist.. when it does.. and also after I run go generate it seems to miss the new stuff stringer creates.

[stamblerre]

I've just tagged a pre-release of gopls that has the fix in: go get golang.org/x/tools/gopls@v0.2.0-pre2 should download it now. Whenever you get a chance, please let me know if that fixed the issue.

[ilanpillemer]

will do when I get back home later.

[ilanpillemer]

I am still getting errors.

I changed my startup script to this (commenting out the install steps).. maybe I did this wrong?

[  "$(pgrep acme-lsp)" ] && kill `pgrep acme-lsp`
[  "$(pgrep gopls)" ] && kill `pgrep gopls`
# GO111MODULE=on go get golang.org/x/tools/gopls@latest
GO111MODULE=on go get golang.org/x/tools/gopls@v0.2.0-pre2
#go get -u golang.org/x/tools/gopls
#cd ~/go/src/golang.org/x/tools/gopls && go install

acme-lsp

and got this stack trace

[Trace - 12:21:42.121 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm/cmd/main.go","diagnostics":[]}


panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x1687364]

goroutine 86 [running]:
golang.org/x/tools/internal/lsp/cache.(*actionHandle).analyze(0xc001fc4960, 0x19a6d20, 0xc000284870, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/cache/analysis.go:151 +0x74
golang.org/x/tools/internal/lsp/cache.(*snapshot).Analyze(0xc00021a6e0, 0x19a6d20, 0xc000284870, 0xc000181c80, 0x32, 0xc001a79000, 0x88, 0x100, 0x0, 0x101, ...)
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/cache/analysis.go:39 +0x25e
golang.org/x/tools/internal/lsp/source.analyses(0x19a6d20, 0xc000284870, 0x19ac8a0, 0xc00021a6e0, 0x19a9f60, 0xc00021ae10, 0x0, 0xc00208a510, 0x1, 0x1)
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/source/diagnostics.go:169 +0x294
golang.org/x/tools/internal/lsp/source.Diagnostics(0x19a6d20, 0xc000284870, 0x19b8960, 0xc0000c6000, 0x27c6840, 0xc0003fa040, 0x0, 0x0, 0x0, 0x0, ...)
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/source/diagnostics.go:87 +0x971
golang.org/x/tools/internal/lsp.(*Server).diagnostics(0xc000296840, 0x19b8960, 0xc0000c6000, 0xc000468000, 0x4e, 0x0, 0x0)
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/diagnostics.go:30 +0x2e0
created by golang.org/x/tools/internal/lsp.(*Server).didOpen
        /Users/ilanpillemer/go/pkg/mod/golang.org/x/tools@v0.0.0-20191105003958-c33799150868/internal/lsp/text_synchronization.go:34 +0x1c8
[Trace - 12:21:57.781 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"file:///","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{},"didChangeConfiguration":{},"didChangeWatchedFiles":{},"symbol":{},"executeCommand":{},"workspaceFolders":true},"textDocument":{"synchronization
":{},"completion":{},"hover":{},"signatureHelp":{},"declaration":{},"definition":{},"typeDefinition":{},"implementation":{},"references":{},"documentHighlight":{},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiter
alSupport":{"codeActionKind":{"valueSet":["source.organizeImports"]}}},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"codeLens":{},"documentLink":{},"rename":{},"publishDiagnostics":{},"colorProvider":{},"foldingRange":{},"selectionRange":{
}}},"initializationOptions":{"hoverKind":"FullDocumentation","staticcheck":true},"workspaceFolders":[{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm"},{"uri":"file:///Users/ilanpillemer/Repos
/bxbdigital/bx-mm/bx-pipe","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm/bx-pipe"},{"uri":"file:///Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler","name":"/Users/ilanpillemer/Repos/bxbdigital/bx-mm/internal/bxcompiler"},{"uri":"file:
///Users/ilanpillemer/Repos/bxbdigital/bxrepl/cmd/bxrepl","name":"/Users/ilanpillemer/Repos/bxbdigital/bxrepl/cmd/bxrepl"}]}

[gopherbot]

Change https://golang.org/cl/205500 mentions this issue: internal/lsp: debugging CL for golang/go#35339

[stamblerre]

@ilanpillemer: Just uploaded CL 205500 for you to try again. To install it, cd into your ~/go/src/golang.org/x/tools directory, sync to master, and then select "Download Patch" from the "..." menu in the top right corner. Copy the "Cherry Pick" command and then execute it in the tools directory. Rebuild gopls (cd gopls && go install && cd ..), and then you should be running with the CL.

[ilanpillemer]

will do first thing tomorrow morning (though if sync to latest do I lose static check?) or is static check etc included in the CL patch?