glog: Use Fatalf to exit when writing to logsinks fails #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, our program exited without any message when there are some disk write error (e.g. no space on device). By increasing the severity, we can notice what caused the program exited as the log will be shown on stderr.
atetubou
changed the title
|
I sent this to internal repository first http://cl/748177961. |
atetubou
changed the title
|
@chressie could you review this too? Thanks. |
|
The Fatal call caused an infinite recursion that i haven't noticed before, so I made some changes internally and continue in #76. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, our program exited without any message when there are some disk write error (e.g. no space left on device).
By increasing the severity, we can notice what caused the program exited as the log will be shown on stderr.
This is imported from http://cl/748177961