Skip to content

Fix early file close in jwt cli #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
+5 −4
Merged

Fix early file close in jwt cli #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cmd/jwt/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ package main

import (
"encoding/json"
"errors"
"flag"
"fmt"
"io"
Expand Down Expand Up @@ -74,7 +75,7 @@ func start() error {
}

// Helper func: Read input from specified file or stdin
func loadData(p string) ([]byte, error) {
func loadData(p string) (_ []byte, retErr error) {
if p == "" {
return nil, fmt.Errorf("no path specified")
}
Expand All @@ -91,9 +92,9 @@ func loadData(p string) ([]byte, error) {
return nil, err
}
rdr = f
if err := f.Close(); err != nil {
return nil, err
}
defer func() {
retErr = errors.Join(retErr, f.Close())
}()
}
return io.ReadAll(rdr)
}
Expand Down