-
Notifications
You must be signed in to change notification settings - Fork 19
Support crypto/des #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Support crypto/des #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagood
approved these changes
Aug 24, 2023
Collaborator
dagood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggestions, but LGTM!
Collaborator
Author
|
@ueno @derekparker Please take a look |
Collaborator
Author
|
Weekly remainder: @ueno @derekparker please take a look. Thanks! |
ueno
approved these changes
Sep 14, 2023
Collaborator
ueno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ciphers defined in crypto/des. Note that DES doesn't support CTR nor GCM modes, that's by design.
This is the new public API:
The PR contains a lot of changes because I've refactored AES so it can share almost all the code with DES.
Please review the PR commit by commit, it will be easier. The commit with more changes is 8cf7f70, in which I moved most of the generalized AES code into
cipher.go. The commit ed65759 is not required, as we know the block size for the ciphers we support, but IMO it is more robust to take them from OpenSSL.