Skip to content

Preparation to fix memory leak when using Ref in NativeScript #33532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Preparation to fix memory leak when using Ref in NativeScript #33532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7275dd5
Add a reset method to Reference
PhilWun Nov 7, 2019
b5fbd22
add method to reset reference counters
PhilWun Nov 10, 2019
4f87bc8
Merge branch 'fix_memory_leak' of github.com:Philius342/godot into fi…
PhilWun Nov 10, 2019
b2619d8
Merge branch 'fix_memory_leak' of github.com:Philius342/godot into fi…
PhilWun Nov 10, 2019
ec7bd38
fix format
PhilWun Nov 10, 2019
9e5a0b8
Merge branch 'fix_memory_leak' of github.com:Philius342/godot into fi…
PhilWun Nov 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/reference.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ void Reference::_bind_methods() {
ClassDB::bind_method(D_METHOD("init_ref"), &Reference::init_ref);
ClassDB::bind_method(D_METHOD("reference"), &Reference::reference);
ClassDB::bind_method(D_METHOD("unreference"), &Reference::unreference);
ClassDB::bind_method(D_METHOD("reset_ref"), &Reference::reset_ref);
}

int Reference::reference_get_count() const {
Expand Down Expand Up @@ -102,6 +103,12 @@ bool Reference::unreference() {
return die;
}

void Reference::reset_ref() {

refcount.init();
refcount_init.init();
}

Reference::Reference() {

refcount.init();
Expand Down
1 change: 1 addition & 0 deletions core/reference.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class Reference : public Object {
bool init_ref();
bool reference(); // returns false if refcount is at zero and didn't get increased
bool unreference();
void reset_ref();
int reference_get_count() const;

Reference();
Expand Down