Edit "Core types" descriptions #11317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
added
enhancement
area:engine details
Ivorforce
force-pushed
the
core-types-update
branch
from
91d44a1 to
4d4e346
Compare
mhilbrunner
approved these changes
Sep 22, 2025
Calinou
reviewed
Sep 22, 2025
| | |span| | ``std::span`` | Represents read-only access to a contiguous array without needing to copy any data. | | ||
| | | | See `pull request description <https://github.com/godotengine/godot/pull/100293>`__ | | ||
| | | | for details. | | ||
| | | | Note that ``Span`` is designed to be a high performance API: It does not perform | |
Member
There was a problem hiding this comment.
Suggested change
| | | | Note that ``Span`` is designed to be a high performance API: It does not perform | | |
| | | | Note that ``Span`` is designed to be a high performance API: it does not perform | |
Member
There was a problem hiding this comment.
You reverted this change, was that intentional?
Member
Author
There was a problem hiding this comment.
When I looked at this, the discussion was already resolved, so I assumed it wasn't relevant after all. Doesn't the sentence after a semicolon begin uppercase if it's a full sentence?
…` (discourage its use), `Span` (make it's clear it's low level API), and `String` (clarify UTF-32 motivation).
Ivorforce
force-pushed
the
core-types-update
branch
from
934cdaf to
56555c7
Compare
Member
|
Thank you! |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair: MentionKeyValue.KeyValuecould get its own entry, but there is nothing much to say, andKeyValueis unlikely to be used outside of containers.RBMap: Discourage its use. We might actually phase it out fully in the future.Span: Make it clear it's low level API. People should be careful when using this.String: Clarify UTF-32 motivation. UTF-32 isn't actually more performant in all respects (it's a RAM hog), but it is simpler to work with.