Skip to content

Conversation

@sheepandshepherd
Copy link
Contributor

Fixes godotengine/godot#32502.

new_string was adding a reference to this without removing it.

It looks like #307 also fixes this leak by cleaning up the way the underlying godot_string is accessed. Not sure if there's a reason it wasn't merged 2 months ago, but if the cleaner style is preferred, that one should be merged instead.

@2shady4u
Copy link
Contributor

Looks good to me 👌

@akien-mga akien-mga merged commit 81783c6 into godotengine:master Jan 19, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GDNative godot::String concatenation memory leak

3 participants