Update GDVIRTUAL*() macros to match Godot 4.4
#1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
gdvirtual-required-macros
branch
2 times, most recently
from
0abaaa8 to
3ac8965
Compare
Ivorforce
approved these changes
Feb 26, 2025
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
Seems fine to me. Haven't tested the code though.
dsnopek
force-pushed
the
gdvirtual-required-macros
branch
from
3ac8965 to
4a9409a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Godot PR godotengine/godot#93311, we changed the way that required virtual methods were registered, so that the
extension_api.jsoncould denote which virtual methods were required.This PR aims to bring the same changes to godot-cpp! This is important to allow the same API as used in Godot modules.
Unfortunately, this PR depends on PR godotengine/godot#103302, which corrects a small mistake that I made in the original Godot PR, so this will fail CI for the moment :-/UPDATE: The Godot PR has been merged, so this should build fine now!