Skip to content

[Web] Don't cache emsdk #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2024
Merged

[Web] Don't cache emsdk #1639

merged 1 commit into from
Nov 11, 2024

Conversation

@AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Nov 10, 2024

@AThousandShips
[Web] Don't cache emsdk
1e3b24f 
Due to how caches are accessed this cache is almost useless, it only
matters if it is from the same branch or a base branch, and is identical
between branches, so caching it just clutters the build cache
@AThousandShips AThousandShips added bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup cherrypick:3.x cherrypick:3.5 cherrypick:4.0 cherrypick:4.1 cherrypick:4.2 cherrypick:4.3 labels Nov 10, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Nov 10, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner November 10, 2024 20:01
dsnopek
dsnopek approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems to match what was done in the Godot repo :-)

@dsnopek dsnopek merged commit f298ddd into godotengine:master Nov 11, 2024
12 checks passed
@AThousandShips AThousandShips deleted the emsdk_cache_fix branch November 11, 2024 17:24
@AThousandShips
Copy link
Member Author

AThousandShips commented Nov 11, 2024

Thank you!

@Ivorforce Ivorforce mentioned this pull request Nov 26, 2024
Merged
@dsnopek
Copy link
Collaborator

dsnopek commented Jan 27, 2025

Cherry-picked for 4.2 in PR #1694

@dsnopek
Copy link
Collaborator

dsnopek commented Jan 27, 2025

Cherry-picked for 4.3 in PR #1695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

bug This has been identified as a bug cherrypick:3.x cherrypick:3.5 cherrypick:4.0 cherrypick:4.1 enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

2 participants

@AThousandShips @dsnopek