Cherrypicks "[SCons] Enable WASM_BIGINT in web builds" into 4.3 branch #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required since Godot 4.3, which is also the first Godot version with wide WASM gdnative support (previous versions were Chrome-only, and very brittle).
fire
approved these changes
Oct 5, 2024
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
We needed this so probably want another approve to avoid bias.
Ivorforce
approved these changes
Oct 28, 2024
Member
Ivorforce
left a comment
Ivorforce
left a comment
There was a problem hiding this comment.
LGTM. My project also only runs on web with this patch.
Collaborator
|
I've got this one in the next batch cherry-picking PR #1632 as well |
Collaborator
|
This was merged with PR #1632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was marked as cherrypick-4.3 in the original PR #1603
Godot Sandbox and godot-sqlite are among the known extensions needing this for Web export to function