-
-
Notifications
You must be signed in to change notification settings - Fork 691
Avoid thread_local on MacOS to prevent issues with hot reload
#1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cdea1ad to
08ba2d8
Compare
thread_local on MacOS to prevent issues with hot reloadthread_local on MacOS to prevent issues with hot reload
08ba2d8 to
91833c8
Compare
|
Now that PR #1590 is merged, taking this one out of draft! |
paddy-exe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in the GDExtension meeting and tested by user who created the issue with success.
|
Cherry-picked for 4.3 in PR #1695 |
|
FYI, this PR broke my GDExtension code on macOS, causing the following linker errors: I've resolved the issue for now by passing the option "use_hot_reload=no" to scons when building godot-cpp. |
MacOS builds with hot reload are still working for me. Perhaps doing a |
Fixes #1573
This isn't quite right yet. I think thelock_guardfor reload is in the right place, but the one inWrapped::_set_construct_info()is wrong. We need to lock around the wholememnew()operation, not just the part where we set those variables. I'm not sure the best way to do that yet.UPDATE: This might be OK now. I need to get a good test.
This depends on PR #1590 because it adds another
thread_local, and this way we can address that one too