Fix crash in ClassDB::add_virtual_method() if arguments metadata is the wrong size
#1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If I understand it correctly, the handled failure case here would be a developer error. I would argue instead of silently failing, we should check for argument congruity before the loop and hard-fail on problems instead. Or at least, log an error if a problem is detected. |
Collaborator
Author
|
Discussed at the GDExtension meeting: we agreed on adding a warning if the argument and argument metadata count don't match. |
dsnopek
force-pushed
the
classdb-add-virtual-method-arg-metadata-size
branch
from
0f93a61 to
1e169bb
Compare
Collaborator
Author
|
Added a warning as discussed at the meeting |
Collaborator
Author
|
Cherry-picked for 4.3 in PR #1695 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580
However, this shouldn't ever happen, if developers use the
GDVIRTUAL*()macros, which will always call this with arguments metadata of the correct size.