Make sure _get and _set dispatch up the class hierarchy
#1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naros
force-pushed
the
dispatch-get-set-up-hierarchy
branch
from
f3d5629 to
904c2f4
Compare
Collaborator
|
Thanks!
Yeah, if we can align with in-engine modules, I'm all for it. However, I think this still doesn't completely match the behavior in modules. Looking in if (m_inherits::_setv(p_name, p_property)) { \
return true; \
} \
if (m_class::_get_set() != m_inherits::_get_set()) { \
return _set(p_name, p_property); \
} \
return false; \Which looks like it tries the parent first, and then if the parent doesn't have that property, it tries the child. Whereas the changes in this PR have it try the child first, and if it doesn't have that property, it tries the parent. |
Naros
force-pushed
the
dispatch-get-set-up-hierarchy
branch
from
904c2f4 to
9d5a5ab
Compare
Naros
force-pushed
the
dispatch-get-set-up-hierarchy
branch
from
9d5a5ab to
c77d44f
Compare
dsnopek
approved these changes
Aug 1, 2024
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me :-)
Collaborator
|
Cherry-picked for 4.2 in PR #1570 |
Collaborator
|
Cherry-picked for 4.1 in PR #1572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsnopek this is in response to my question from chat. It seems a bit odd to me that
_get_property_listdispatches up the class hierarchy while calls to_getand_setdo not and expect the developer to call the super type internally. I'm not sure whether we want to alter this behavior or leave it as-is and document this nuance for others who may prefer to use these override methods for property management.This change also seems to align the GDExtension behavior with C++ modules, too.