Add a test to ensure that library path is absolute #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
enhancement
dsnopek
force-pushed
the
test-library-path-absolute
branch
from
349ba3b to
8e6482b
Compare
dsnopek
force-pushed
the
test-library-path-absolute
branch
from
8e6482b to
92ace04
Compare
Collaborator
Author
|
Whoops! I didn't mean to actually click the merge button on that one. It only adds a test, though, and the test is passing so I think everything will be OK. :-) |
Collaborator
Author
|
Cherry-picked for 4.3 in PR #1569 |
Collaborator
Author
|
Cherry-picked for 4.2 in PR #1570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two times now we have broken
get_library_pathsuch that it doesn't return an absolute path.See:
GDExtension'slibrary_pathback to an absolute path godot#84620library_pathas absolute path godot#94373This is a Godot issue, but this PR adds a test to CI that will verify that the path is absolute, in order to try and help us not break it again.
This will fail CI until PR godotengine/godot#94373 is merged