Skip to content

Conversation

@akien-mga
Copy link
Member

Draft, still need to test.

@akien-mga
Copy link
Member Author

akien-mga commented Sep 21, 2023

@bruvzg With those precompiled macOS libs, I'm having the same issue as for official MoltenVK when linking:

/root/osxcross/target/bin/arm64-apple-darwin22-c++ -o bin/godot.macos.editor.arm64 -arch arm64 -mmacosx-version-min=11.0 -framework Cocoa -framework Carbon -framework AudioUnit -framework CoreAudio -framework CoreMIDI -framew>
ld: warning: option -s is obsolete and being ignored
Undefined symbols for architecture arm64:
  "_objc_msgSend$GPUEndTime", referenced from:
      rx::mtl::CommandQueue::onCommandBufferCompleted(objc_object objcproto16MTLCommandBuffer*, unsigned long long, unsigned long long) in libANGLE.macos.arm64.a(mtl_command_buffer.macos.arm64.o)
  "_objc_msgSend$GPUStartTime", referenced from:
      rx::mtl::CommandQueue::onCommandBufferCompleted(objc_object objcproto16MTLCommandBuffer*, unsigned long long, unsigned long long) in libANGLE.macos.arm64.a(mtl_command_buffer.macos.arm64.o)
  "_objc_msgSend$UTF8String", referenced from:
      rx::DisplayMtl::initializeShaderLibrary() in libANGLE.macos.arm64.a(DisplayMtl.macos.arm64.o)
      rx::DisplayMtl::getRendererDescription() in libANGLE.macos.arm64.a(DisplayMtl.macos.arm64.o)
      rx::DisplayMtl::getVersionString(bool) in libANGLE.macos.arm64.a(DisplayMtl.macos.arm64.o)
      rx::mtl::CreateMslShader(rx::mtl::Context*, objc_object objcproto10MTLLibrary*, NSString*, MTLFunctionConstantValues*, objc_object objcproto11MTLFunction**) in libANGLE.macos.arm64.a(mtl_utils.macos.arm64.o)
      rx::(anonymous namespace)::CreateMslShaderLib(rx::ContextMtl*, gl::InfoLog&, rx::mtl::TranslatedShaderInfo*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1:>
      rx::mtl::FormatMetalErrorMessage(NSError*) in libANGLE.macos.arm64.a(mtl_common.macos.arm64.o)

Still using LLVM Clang 14 for now, I haven't done the switch yet to my WIP update to Apple Clang 15. I might focus on this next if that makes our life simpler.

@akien-mga
Copy link
Member Author

akien-mga commented Sep 25, 2023

Still using LLVM Clang 14 for now, I haven't done the switch yet to my WIP update to Apple Clang 15. I might focus on this next if that makes our life simpler.

Still having the same issue with Apple Clang (based on LLVM 15.0.0) via osxcross, with Xcode 14.3.1.

Edit: And same issue with Apple Clang based on LLVM 16.0.0, with Xcode 15.0.

@akien-mga
Copy link
Member Author

With the new builds made by @bruvzg today, I could link successfully for both Windows and macOS: https://github.com/godotengine/godot-angle-static/releases/tag/chromium%2F6029

@akien-mga akien-mga marked this pull request as ready for review September 25, 2023 13:33
@akien-mga akien-mga merged commit 02e092c into main Sep 25, 2023
@akien-mga akien-mga deleted the angle-libs branch September 25, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant