Add the react, app-connect, and localizaton packages. #1188
+40,899
−1,565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcole1-godaddy
force-pushed
the
godaddy-dev-js-libraries
branch
from
505add7 to
ba52910
Compare
…g generation - Fixed canonicalizeRequest function to prioritize req.path over req.url - This ensures proper signature verification when path is explicitly provided - All tests now pass including signature verification tests Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-b920e286-dc84-414e-bd6c-5cc01f8216c6
- Added build script to root package.json that builds all packages - Modified test script to run build first, ensuring workspace dependencies are available - This fixes CI failures where react tests failed due to @godaddy/localizations not being built - Resolves workspace dependency resolution issues in GitHub Actions Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-b920e286-dc84-414e-bd6c-5cc01f8216c6
Amp-Thread-ID: https://ampcode.com/threads/T-99bd6b08-f098-4849-a852-c6b83a9a24b0 Co-authored-by: Amp <[email protected]>
Co-authored-by: Rick Markins <[email protected]>
Co-authored-by: Rick Markins <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-eb0b6a58-0d4f-4ca8-a95f-e7b670beec77 Co-authored-by: Amp <[email protected]>
wcole1-godaddy
force-pushed
the
godaddy-dev-js-libraries
branch
from
ba52910 to
3943954
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-eb0b6a58-0d4f-4ca8-a95f-e7b670beec77 Co-authored-by: Amp <[email protected]>
packages/react/src/components/checkout/payment/checkout-buttons/credit-card/square.tsx
Show resolved
Hide resolved
Amp-Thread-ID: https://ampcode.com/threads/T-ba76b785-18f2-4b86-ac29-695004d61704 Co-authored-by: Amp <[email protected]>
- Kept updated README format with comprehensive package table - Added biome-config-godaddy package reference from main - Resolved pnpm-lock.yaml conflicts Amp-Thread-ID: https://ampcode.com/threads/T-6fc81469-d25f-470f-966b-1e45c2474749 Co-authored-by: Amp <[email protected]>
akazemier-godaddy
approved these changes
Oct 24, 2025
kawikabader
approved these changes
Oct 24, 2025
rmarkins-godaddy
approved these changes
Oct 24, 2025
| @@ -0,0 +1,23 @@ | |||
| # AGENTS.md - GoDaddy JavaScript Style Guide | |||
There was a problem hiding this comment.
This should just be GoDaddy JavaScript since it's no longer including components that are just for linting and formatting.
| "build": "pnpm run -r build", | ||
| "lint": "pnpm run -r lint", | ||
| "test": "pnpm run -r --parallel test", | ||
| "test": "pnpm run build && pnpm run -r --parallel test", |
There was a problem hiding this comment.
the build script could be a pretest hook instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This marks the first stable major release of our GoDaddy JavaScript libraries, representing a significant milestone in our platform development.
A comprehensive React component library for GoDaddy checkout experiences, featuring:
Internationalization support for GoDaddy checkout components:
Essential platform integration tools for GoDaddy app developers:
These packages provide the foundation for building robust, secure, and internationalized applications on the GoDaddy platform.
Changeset
Test Plan