Skip to content

Conversation

@sirlori
Copy link
Contributor

@sirlori sirlori commented Jun 27, 2015

This bug, made receive always a request, an often always the same one.
I fixed it, now my echotest bot works like a charm!

I could contribute with a command-parsing struct and some tests if you'd like. Let me know!

Syfaro pushed a commit that referenced this pull request Jun 27, 2015
Fix on the updaterequest
@Syfaro Syfaro merged commit 0105ee9 into go-telegram-bot-api:master Jun 27, 2015
@Syfaro
Copy link
Member

Syfaro commented Jun 27, 2015

Thank you for catching this issue.

I'd be happy to get any contributions you'd be willing to write!
What do you mean by a command-parsing struct?

@sirlori
Copy link
Contributor Author

sirlori commented Jun 27, 2015

Well, I couldn't say an object so I said struct but I realize now that was ... Not appropriate.
I mean a set of helpers (some structs and functions) to decode telegram bot's /commands safely.
Do you think that is a good idea?

@Syfaro
Copy link
Member

Syfaro commented Jun 27, 2015

I think that this should be just an API implementation with no additional functions, and then create another package with functions for that, and another package that's a framework for creating a bot with plugins, etc.

Or what exactly were you talking about with decoding commands safely? I'm not sure what kinds of features you're suggesting exactly.

Syfaro pushed a commit that referenced this pull request Jul 6, 2015
Syfaro pushed a commit that referenced this pull request Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants