Add _binary prefix when interpolating []byte data. #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 5.6.27, mysql server produces a warning if string literals cannot be interpreted in a given character set (see Bug #20238729). As a consequence, the driver may fail to insert []byte data into BLOB columns when interpolateParams is true. This commit adds "_binary" encoding prefix when interpolating []byte data to avoid that warning. http://dev.mysql.com/doc/refman/5.7/en/charset-literal.html
Contributor
Author
|
@arnehormann @julienschmidt |
Member
|
@ymmt2005 thank you for the PR; I was unsure if this is supported in 4.1 - apparently it is (page 654). Thanks also to @methane! LGTM Congrats for your first merged PR! |
arnehormann
added a commit
that referenced
this pull request
Nov 12, 2015
Add _binary prefix when interpolating []byte data.
methane
added a commit
to methane/PyMySQL
that referenced
this pull request
Jan 8, 2016
On Python 2, bytearray represents binary data. On Python 3, bytes and bytearray represents binary data. reference: go-sql-driver/mysql#382 https://dev.mysql.com/doc/relnotes/mysql/5.5/en/news-5-5-46.html https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-27.html
|
Hi, if I'm using an older version of mysql, can this change introduce compatibility issues? We've encountered a problems very likely related to this, but I'm not entirely sure. Could you provide more infos regarding compatibility with older mysql please? |
Contributor
Author
|
From the old reference, it seems that MySQL 4.1 supports Run the following commands in your shell to see if your MySQL supports |
nicolestandifer3
added a commit
to nicolestandifer3/MySQL-test-repos
that referenced
this pull request
Aug 6, 2023
On Python 2, bytearray represents binary data. On Python 3, bytes and bytearray represents binary data. reference: go-sql-driver/mysql#382 https://dev.mysql.com/doc/relnotes/mysql/5.5/en/news-5-5-46.html https://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-27.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revise of #381.
Since 5.6.27, mysql server produces a warning if string literals cannot
be interpreted in a given character set (see Bug #20238729).
As a consequence, the driver may fail to insert []byte data into
BLOB columns when interpolateParams is true in strict SQL mode.
This commit adds "_binary" encoding prefix when interpolating []byte data
to avoid that warning.
http://dev.mysql.com/doc/refman/5.7/en/charset-literal.html