remove eof field from mysqlRows #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
clicked the wrong button 😢 |
rows.go
Outdated
Member
There was a problem hiding this comment.
This has no advantage over a named return value
Member
|
LGTM |
arnehormann
added a commit
that referenced
this pull request
Oct 30, 2013
remove eof field from mysqlRows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eofinmysqlRowsis not necessary.The rows reached
io.EOFwhenmc == nil, the packet is incomplete (because the connection was closed) whenmc.netConn == nil.I'm planning on issuing followup PRs, but I want to keep them small and reviewable, so we'll start with this.