New DSN parser #130
Merged
New DSN parser #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Set right default addr for net=unix Go 1.2RC1 BenchmarkParseDSN_new 200000 10545 ns/op 4039 B/op 42 allocs/op BenchmarkParseDSN_old 10000 233313 ns/op 7588 B/op 91 allocs/op Go 1.1 BenchmarkParseDSN_new 200000 7940 ns/op 4204 B/op 42 allocs/op BenchmarkParseDSN_old 10000 264115 ns/op 8083 B/op 91 allocs/op
Not really a behavior change, since it was mostly broken before
|
When we depend on Go 1.2, we can use strings.IndexByte (implemented via SIMD). This removes the find-loops and lets to code look a bit nice 😉 |
utils.go
Outdated
There was a problem hiding this comment.
...or addr if it's a socket. Also, drop the parens?
// Find the last '/', prior slashes may be part of password or addr
ghost
assigned
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new parser, which doesn't use RegExp.
Go 1.2RC1
The current RC has too many string (slice) bound checks, I guess. Go 1.1 is a bit faster:
Go 1.1
Moreover, this PR requires DSN param values to be escaped with url.QueryEscape. Before, values couldn't contain special characters like
&because the ampersand is the param delimiter.